[uc] Improve chunk upload AssemblyStream performance #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@icewind1991, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @LukasReschke and @nickvergessen to be potential reviewers |
|
Let me smash this, to be sure |
|
Ran the tests for big files, they still pass |
|
I pushed the updated autoloader code. cc @rullzer |
|
👍 |
Ah ... @icewind1991 just pushed shortly before me 😄 |
MorrisJobke
force-pushed
the
dav-fixassemblystreamperf
branch
from
69ac1ef
to
d404424
Compare
Rebased to resolve the conflict |
rullzer
force-pushed
the
dav-fixassemblystreamperf
branch
from
d404424
to
1ab472b
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstreaming of owncloud/core#26062